fix a few potential bugs

try gitlab in the meanwhile

.gitlab-ci.yml

+job:
+  image: golang:1.12.7-stretch
+
+  variables:
+    GO111MODULE: "on"
+
+  script:
+    #Fetch master to be used in deploy condition to prevent deploying on old commits.
+    - whoami && pwd
+    - ./e2e/e2e.sh
+
+  cache:
+    key: "$CI_COMMIT_REF_SLUG"
+    paths:
+      - $HOME/.cache/go-build
+      - $HOME/gopath/pkg/mod
+
+  before_script:
+    - apt update -q && apt install -qqy --no-install-recommends locales-all sudo youtube-dl ffmpeg tree curl
+    - apt install -qqy --no-install-recommends py-pip python-dev libffi-dev openssl-dev gcc libc-dev make
+    - curl -fsSL https://get.docker.com -o get-docker.sh
+    - sudo sh get-docker.sh
+    - sudo usermod -aG docker $USER
+    - sudo curl -L "https://github.com/docker/compose/releases/download/1.24.1/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose
+    - sudo chmod +x /usr/local/bin/docker-compose
+    - sudo ln -s /usr/local/bin/docker-compose /usr/bin/docker-compose

e2e/e2e.sh

@@ -22,9 +22,9 @@ export REFLECT_BLOBS=false
 export CLEAN_ON_STARTUP=true
 export REGTEST=true
 # Local settings
-export BLOBS_DIRECTORY="`pwd`/e2e/blobsfiles"
-export LBRYNET_DIR="`pwd`/e2e/persist/.lbrynet/.local/share/lbry/lbrynet/"
-export LBRYNET_WALLETS_DIR="`pwd`/e2e/persist/.lbrynet/.local/share/lbry/lbryum"
+export BLOBS_DIRECTORY="$(pwd)/e2e/blobsfiles"
+export LBRYNET_DIR="$(pwd)/e2e/persist/.lbrynet/.local/share/lbry/lbrynet/"
+export LBRYNET_WALLETS_DIR="$(pwd)/e2e/persist/.lbrynet/.local/share/lbry/lbryum"
 export TMP_DIR="/var/tmp"
 
 cd ./e2e
@@ -37,10 +37,11 @@ mkdir persist
 mkdir -p blobsfiles
 mkdir persist/.lbrynet
 ls -lha ./persist
+chown "$USER": -R ./persist
 chmod u+rwx ./persist/.lbrynet
 docker-compose up -d
 printf 'waiting for internal apis'
-until $(curl --output /dev/null --silent --head --fail http://localhost:15400); do
+until curl --output /dev/null --silent --head --fail http://localhost:15400; do
     printf '.'
     sleep 1
 done