Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L lbry
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 172
    • Issues 172
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lbry
  • lbry
  • Merge requests
  • !730

Merged
Created Jun 23, 2017 by ci@lbry_ciOwner

Fix claim_show (API change)

  • Overview 4
  • Commits 6
  • Changes 4

Created by: kaykurokawa

Initially was just fixing docstring bug where name was required in claim_show but found a bunch of other problems. This will be an API change.

  1. Removed argument 'name' from claim_show. This is redundant because API command resolve should handle name resolution. The purpose of this command is to check a claim if the only information you have about it is the outpoint, or the claim ID. If want to look up a claim by both name and claim_id you can use resolve (https://github.com/lbryio/lbry/issues/644)

  2. The command would return different outputs if the claim didn't exist depending on if you fed it a txid/nout or Claim ID. Make them consistent and return a {'error':'reason...'} dictionary like you would get in API command resolve.

Also made some DRY fixes to the wallet where it decodes and caches claim results.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix_claim_show_args