Fix claim_show (API change)
Created by: kaykurokawa
Initially was just fixing docstring bug where name was required in claim_show but found a bunch of other problems. This will be an API change.
-
Removed argument 'name' from claim_show. This is redundant because API command resolve should handle name resolution. The purpose of this command is to check a claim if the only information you have about it is the outpoint, or the claim ID. If want to look up a claim by both name and claim_id you can use resolve (https://github.com/lbryio/lbry/issues/644)
-
The command would return different outputs if the claim didn't exist depending on if you fed it a txid/nout or Claim ID. Make them consistent and return a {'error':'reason...'} dictionary like you would get in API command resolve.
Also made some DRY fixes to the wallet where it decodes and caches claim results.